Skip to content

Commit

Permalink
fix(material-experimental/mdc-slider): remove deep imports (#23451)
Browse files Browse the repository at this point in the history
Fixes a couple of deep imports in the `mdc-slider` package that were causing the CLI to log a warning when the package is installed.

(cherry picked from commit 81b6b6b)
  • Loading branch information
crisbeto authored and andrewseguin committed Sep 10, 2021
1 parent 63f127b commit 4fa5e6c
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
4 changes: 0 additions & 4 deletions rollup-globals.bzl
Expand Up @@ -38,10 +38,6 @@ ROLLUP_GLOBALS = {
"@angular/material-luxon-adapter": "ng.materialLuxonAdapter",
"@angular/youtube-player": "ng.youtubePlayer",

# This UMD module name would not match with anything that MDC provides, but we just
# add this to make the linter happy. This module resolves to a type-only file anyways.
"@material/base/types": "mdc.base.types",

# Third-party libraries.
"kagekiri": "kagekiri",
"moment": "moment",
Expand Down
1 change: 1 addition & 0 deletions src/material-experimental/mdc-slider/BUILD.bazel
Expand Up @@ -27,6 +27,7 @@ ng_module(
"//src/cdk/platform",
"//src/material-experimental/mdc-core",
"@npm//@angular/forms",
"@npm//@material/base",
"@npm//@material/slider",
],
)
Expand Down
Expand Up @@ -8,7 +8,7 @@

import {DOCUMENT} from '@angular/common';
import {Inject, Injectable, NgZone, OnDestroy} from '@angular/core';
import {SpecificEventListener} from '@material/base/types';
import {SpecificEventListener} from '@material/base';
import {fromEvent, Observable, Subject, Subscription} from 'rxjs';
import {finalize, share, takeUntil} from 'rxjs/operators';

Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-slider/slider.ts
Expand Up @@ -50,7 +50,7 @@ import {
RippleState,
} from '@angular/material/core';
import {ANIMATION_MODULE_TYPE} from '@angular/platform-browser/animations';
import {SpecificEventListener, EventType} from '@material/base/types';
import {SpecificEventListener, EventType} from '@material/base';
import {MDCSliderAdapter, MDCSliderFoundation, Thumb, TickMark} from '@material/slider';
import {Subscription} from 'rxjs';
import {GlobalChangeAndInputListener} from './global-change-and-input-listener';
Expand Down

0 comments on commit 4fa5e6c

Please sign in to comment.