Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/coercion): add the support for readonly array coercion #18807

Merged
merged 1 commit into from Mar 21, 2020
Merged

fix(cdk/coercion): add the support for readonly array coercion #18807

merged 1 commit into from Mar 21, 2020

Conversation

klemenoslaj
Copy link
Contributor

Fixes a type definition of coerceArray so that it accepts both mutable and
immutable arrays.

Fixes #18806

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2020
@klemenoslaj klemenoslaj force-pushed the support-readonly-array-coercion branch from cae94df to bbba33c Compare March 12, 2020 13:01
crisbeto
crisbeto reviewed Mar 12, 2020
View reviewed changes
src/cdk/coercion/array.ts Outdated Show resolved Hide resolved
@klemenoslaj
fix(cdk/coercion): add the support for readonly array coercion
b763107 
Fixes a type definition of coerceArray so that it accepts both mutable and
immutable arrays.

Fixes angular#18806
@klemenoslaj klemenoslaj force-pushed the support-readonly-array-coercion branch from bbba33c to b763107 Compare March 12, 2020 21:24
jelbourn
jelbourn approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 12, 2020
@klemenoslaj
Copy link
Contributor Author

@crisbeto I updated the code according to your comment. Can you have a look?

@klemenoslaj
Copy link
Contributor Author

klemenoslaj commented Mar 19, 2020 •
edited

LGTM

@jelbourn Thanks 👍

ci/angular merge status is still blocking while the tag was added. Am I missing something?

@mmalerba mmalerba merged commit cd96886 into angular:master Mar 21, 2020
@klemenoslaj klemenoslaj deleted the support-readonly-array-coercion branch March 21, 2020 13:06
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
This was referenced Apr 17, 2020
Merged
Merged
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk): coerceArray doesn't work with readonly arrays
6 participants
@klemenoslaj @jelbourn @crisbeto @devversion @googlebot @mmalerba