Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): add feature targeting to theme styles #18830

Merged
merged 1 commit into from Mar 21, 2020
Merged

fix(material-experimental/mdc-chips): add feature targeting to theme styles #18830

merged 1 commit into from Mar 21, 2020

Conversation

crisbeto
Copy link
Member

The MDC chips theme was including some styles without a feature target, resulting in some unnecessary styles being added.

@crisbeto
fix(material-experimental/mdc-chips): add feature targeting to theme …
778502e 
…styles

The MDC chips theme was including some styles without a feature target, resulting in some unnecessary styles being added.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 14, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner March 14, 2020 18:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2020
mmalerba
mmalerba approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 16, 2020
@mmalerba mmalerba merged commit 54bbb90 into angular:master Mar 21, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
This was referenced Apr 17, 2020
Merged
Merged
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @mmalerba @googlebot