Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/slide-toggle): redefine more variables #18908

Merged
merged 1 commit into from Mar 25, 2020
Merged

fix(material-experimental/slide-toggle): redefine more variables #18908

merged 1 commit into from Mar 25, 2020

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 24, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 24, 2020
@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 25, 2020
mmalerba
mmalerba approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crisbeto
crisbeto approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin requested review from crisbeto, devversion and mmalerba and removed request for devversion March 25, 2020 13:44
@andrewseguin andrewseguin merged commit 1cca459 into angular:master Mar 25, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
This was referenced Apr 17, 2020
Merged
Merged
Closed
Merged
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewseguin @crisbeto @devversion @mmalerba @googlebot