fix(material/button-toggle): fix ChromeVox focus issue on button toggle #21046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
Accessibility
google-cla
bot
added
the
cla: yes
annieyw
force-pushed
the
button-toggle-aria
branch
from
5638290
to
83acefe
Compare
crisbeto
reviewed
Nov 14, 2020
annieyw
force-pushed
the
button-toggle-aria
branch
2 times, most recently
from
c61d6a4
to
f056c04
Compare
crisbeto
approved these changes
Nov 17, 2020
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
nit: you can simplify this to:
focusableChild?.focus();
return !!focusableChild;
annieyw
force-pushed
the
button-toggle-aria
branch
from
f056c04
to
287aa43
Compare
annieyw
added
merge: caretaker note
|
Note: people may be calling |
|
@annieyw One of your commit messages isn't formatted correctly |
…dkFocusInitial element isn't focusable
annieyw
force-pushed
the
button-toggle-aria
branch
from
287aa43
to
66b07e8
Compare
|
fixed commit message |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 11, 2020
Removes the `tabindex` from the host node, because it causes some a11y issues. We had it there before so that things like `cdkFocusInitial` would work, but after angular#21046 it isn't necessary anymore. Fixes angular#21266.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes focus issue with Chromevox in which you need to hit arrow key twice to move to the next button-toggle.