fix(material-experimental/mdc-chips): set correct ripple opacity for … #21624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
P2
google-cla
bot
added
the
cla: yes
annieyw
force-pushed
the
chips-ripple-opacity
branch
from
07b8790
to
8c0381f
Compare
crisbeto
reviewed
Jan 19, 2021
| &:not(:focus) { | ||
| .mdc-chip__ripple { | ||
| opacity: 0; | ||
| } |
There was a problem hiding this comment.
This increases the specificity a lot and makes it harder to change the opacity to something else, e.g. if we needed a different one on hover. Based on these styles, the element should be transparent by default. Maybe this indicates that there's a different issue someplace else?
There was a problem hiding this comment.
Changed to including different mixins instead of increasing specificity
annieyw
force-pushed
the
chips-ripple-opacity
branch
from
8c0381f
to
8ffe0b3
Compare
annieyw
force-pushed
the
chips-ripple-opacity
branch
from
8ffe0b3
to
6ec4a81
Compare
annieyw
force-pushed
the
chips-ripple-opacity
branch
from
6ec4a81
to
f2460a6
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 26, 2021
angular#21624) * fix(material-experimental/mdc-chips): set correct ripple opacity for focus states * fix(material-experimental/mdc-chips): extract styles into mixin
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 29, 2021
angular#21624) * fix(material-experimental/mdc-chips): set correct ripple opacity for focus states * fix(material-experimental/mdc-chips): extract styles into mixin
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
angular#21624) * fix(material-experimental/mdc-chips): set correct ripple opacity for focus states * fix(material-experimental/mdc-chips): extract styles into mixin
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
angular#21624) * fix(material-experimental/mdc-chips): set correct ripple opacity for focus states * fix(material-experimental/mdc-chips): extract styles into mixin
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…focus states
Previously the ripple was always set to the focus opacity for selected chips even when not focused.
This is because
mdc-chip-fill-color-accessibleincludesmdc-chip-selected-ink-colorwhich overrides the default ripple opacity so the focus ripple is always visible for selected chips.The first chip is focused for both images.
Before
After
