Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): clear tabindex from host node #21633

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

crisbeto
Copy link
Member

Similar to #21280. Removes the tabindex from the mat-datepicker-toggle host since it can caused accessibility issues. It was only there as a workaround which isn't required after #21046.

Similar to angular#21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after angular#21046.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 19, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 19, 2021
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 19, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 2e783b4 into angular:master Jan 25, 2021
andrewseguin pushed a commit that referenced this pull request Jan 25, 2021
Similar to #21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after #21046.

(cherry picked from commit 2e783b4)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 26, 2021
Similar to angular#21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after angular#21046.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 29, 2021
Similar to angular#21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after angular#21046.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
Similar to angular#21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after angular#21046.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
Similar to angular#21280. Removes the `tabindex` from the `mat-datepicker-toggle` host since it
can caused accessibility issues. It was only there as a workaround which isn't required
after angular#21046.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants