-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/datepicker): mark date input as touched when calendar is closed #21646
Merged
andrewseguin
merged 1 commit into
angular:master
from
crisbeto:21643/datepicker-closed-touched
Jan 25, 2021
Merged
fix(material/datepicker): mark date input as touched when calendar is closed #21646
andrewseguin
merged 1 commit into
angular:master
from
crisbeto:21643/datepicker-closed-touched
Jan 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closed Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes angular#21643.
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
labels
Jan 20, 2021
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Jan 20, 2021
mmalerba
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewseguin
pushed a commit
that referenced
this pull request
Jan 25, 2021
… closed (#21646) Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes #21643. (cherry picked from commit b559786)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 26, 2021
… closed (angular#21646) Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes angular#21643.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 29, 2021
… closed (angular#21646) Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes angular#21643.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
… closed (angular#21646) Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes angular#21643.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
… closed (angular#21646) Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it. These changes add some logic to mark the inputs as touched when the calendar is closed as well. Fixes angular#21643.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we mark the date input model as touched when it is blurred or the user types something in, however opening and closing the calendar is also an indicator that the user has interacted with it.
These changes add some logic to mark the inputs as touched when the calendar is closed as well.
Fixes #21643.