fix(cdk/overlay): overriding pointer-events style #21666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set `pointer-events: auto` on the overlay when it is attached and then `none` while it's detaching which ends up overriding any other styles the user might have. These changes reset to `''` instead. Fixes angular#21656.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jbedard
reviewed
Jan 21, 2021
| @@ -368,7 +368,7 @@ export class OverlayRef implements PortalOutlet, OverlayReference { | |||
|
|
|||
| /** Toggles the pointer events for the overlay pane element. */ | |||
| private _togglePointerEvents(enablePointer: boolean) { | |||
There was a problem hiding this comment.
I was debating renaming this at the same time to _disablePointerEvents since it never really does enable them anymore, it just disables or defaults...
There was a problem hiding this comment.
IMO "toggle" still makes sense since the default is for them to be enabled.
There was a problem hiding this comment.
The default is in a css class though, this code really doesn't know and shouldn't care what that default is. Just my opinion though 🤷
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 26, 2021
We set `pointer-events: auto` on the overlay when it is attached and then `none` while it's detaching which ends up overriding any other styles the user might have. These changes reset to `''` instead. Fixes angular#21656.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 29, 2021
We set `pointer-events: auto` on the overlay when it is attached and then `none` while it's detaching which ends up overriding any other styles the user might have. These changes reset to `''` instead. Fixes angular#21656.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
We set `pointer-events: auto` on the overlay when it is attached and then `none` while it's detaching which ends up overriding any other styles the user might have. These changes reset to `''` instead. Fixes angular#21656.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
We set `pointer-events: auto` on the overlay when it is attached and then `none` while it's detaching which ends up overriding any other styles the user might have. These changes reset to `''` instead. Fixes angular#21656.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set
pointer-events: autoon the overlay when it is attached and thennonewhile it's detaching which ends up overriding any other styles the user might have. These changes reset to''instead.Fixes #21656.