Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): pass correct inject flags to injector #22665

Merged
merged 1 commit into from May 18, 2021

Conversation

crisbeto
Copy link
Member

We have a call to Injector.get in the date range input which is supposed to fall back to null if the value doesn't resolve, however we're missing the Optional flag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework.

angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage.

These changes fix our usage in order to unblock the framework PR.

We have a call to `Injector.get` in the date range input which is supposed to fall back to `null` if the value doesn't resolve, however we're missing the `Optional` flag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework.

angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage.

These changes fix our usage in order to unblock the framework PR.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 11, 2021
@crisbeto crisbeto requested a review from mmalerba May 11, 2021 17:27
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2021
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels May 11, 2021
@andrewseguin andrewseguin merged commit 7367823 into angular:master May 18, 2021
andrewseguin pushed a commit that referenced this pull request May 18, 2021
We have a call to `Injector.get` in the date range input which is supposed to fall back to `null` if the value doesn't resolve, however we're missing the `Optional` flag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework.

angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage.

These changes fix our usage in order to unblock the framework PR.

(cherry picked from commit 7367823)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 8, 2021
Fixes a few more cases like angular#22665 where we were injecting something optionally, but we weren't passing the optional injector flag.
wagnermaciel pushed a commit that referenced this pull request Jun 10, 2021
Fixes a few more cases like #22665 where we were injecting something optionally, but we weren't passing the optional injector flag.
wagnermaciel pushed a commit that referenced this pull request Jun 10, 2021
Fixes a few more cases like #22665 where we were injecting something optionally, but we weren't passing the optional injector flag.

(cherry picked from commit fc8a6f9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants