Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/radio): disable ripples under noop animations module #22855

Merged
merged 1 commit into from
Jun 2, 2021
Merged

fix(material/radio): disable ripples under noop animations module #22855

merged 1 commit into from
Jun 2, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 1, 2021

Fixes that we weren't disabling the radio button ripples when the NoopAnimationsModule is used.

@crisbeto
fix(material/radio): disable ripples under noop animations module
5e6506e 
Fixes that we weren't disabling the radio button ripples when the `NoopAnimationsModule` is used.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 1, 2021
@crisbeto crisbeto requested a review from devversion June 1, 2021 15:02
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2021
jelbourn
jelbourn approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 1, 2021
@mmalerba mmalerba merged commit babf80f into angular:master Jun 2, 2021
mmalerba pushed a commit that referenced this pull request Jun 2, 2021
@crisbeto @mmalerba
fix(material/radio): disable ripples under noop animations module (#2…
a3bb573 
…2855)

Fixes that we weren't disabling the radio button ripples when the `NoopAnimationsModule` is used.

(cherry picked from commit babf80f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @devversion @mmalerba