Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): delete isRequired function #22876

Merged
merged 2 commits into from Jun 10, 2021
Merged

fix(material-experimental/mdc-slider): delete isRequired function #22876

merged 2 commits into from Jun 10, 2021

Conversation

wagnermaciel
Copy link
Contributor

  • delete the isRequired function from the MatSliderThumbHarness since
    the 'required' attribute is ignored on range inputs

@wagnermaciel
fix(material-experimental/mdc-slider): delete isRequired function
7e0d811 
* delete the isRequired function from the MatSliderThumbHarness since
  the 'required' attribute is ignored on range inputs
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 3, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review June 3, 2021 21:21
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for devversion June 3, 2021 21:21
crisbeto
crisbeto approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 4, 2021
@wagnermaciel wagnermaciel merged commit 4cee3b7 into angular:master Jun 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagnermaciel @crisbeto @devversion