Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): align test harness inferred position with component #22879

Merged
merged 1 commit into from Jun 16, 2021
Merged

fix(material-experimental/mdc-slider): align test harness inferred position with component #22879

merged 1 commit into from Jun 16, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 4, 2021

Currently the test harness for a thumb assumes that its direction is start unless explicitly specified. This is incosistent with the component itself which assues the opposite.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Jun 4, 2021
@crisbeto crisbeto requested a review from devversion as a code owner June 4, 2021 05:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 7, 2021
wagnermaciel
wagnermaciel approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
fix(material-experimental/mdc-slider): align test harness inferred po…
eefa1e1 
…sition with component

Currently the test harness for a thumb assumes that its direction is `start` unless explicitly specified. This is incosistent with the component itself which assues the opposite.
@wagnermaciel wagnermaciel merged commit 24d33a8 into angular:master Jun 16, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @devversion @wagnermaciel