New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-checkbox): add larger touch target #22892
Merged
wagnermaciel
merged 1 commit into
angular:master
from
crisbeto:mdc-checkbox-touch-target
Jun 16, 2021
Merged
fix(material-experimental/mdc-checkbox): add larger touch target #22892
wagnermaciel
merged 1 commit into
angular:master
from
crisbeto:mdc-checkbox-touch-target
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Accessibility
This issue is related to accessibility (a11y)
target: patch
This PR is targeted for the next patch release
labels
Jun 4, 2021
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Jun 4, 2021
Sets up a larger touch target for checkboxes in order to meet the 48px minimum.
crisbeto
force-pushed
the
mdc-checkbox-touch-target
branch
from
June 9, 2021 05:56
704ab6c
to
aa2e2f5
Compare
mmalerba
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmalerba
added
action: merge
The PR is ready for merge by the caretaker
P2
The issue is important to a large percentage of users, with a workaround
and removed
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
labels
Jun 9, 2021
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 16, 2021
) Sets up a larger touch target for checkboxes in order to meet the 48px minimum. (cherry picked from commit 437aba6)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 16, 2021
Sets up accessible touch targets on the MDC-based radio button. Also hides the touch targets on the two lowest densities. This is something I forgot to do in angular#22892. Fixes angular#22991.
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Accessibility
This issue is related to accessibility (a11y)
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a larger touch target for checkboxes in order to meet the 48px minimum.