Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/schematics): incorrectly migrating some cases #22983

Merged
merged 1 commit into from Jun 16, 2021
Merged

fix(material/schematics): incorrectly migrating some cases #22983

merged 1 commit into from Jun 16, 2021

Conversation

crisbeto
Copy link
Member

Fixes the following cases that the migration wasn't handling correctly:

  • Variables whose names partially match the name of the variables being migrated. E.g. $mat-blue-override.
  • Functions whose names partially match the names of function being migrated. E.g. my-mat-palette.
  • Files where the top import comes from Material, but which have other imports further down in the file.

@crisbeto
fix(material/schematics): incorrectly migrating some cases
75174f8 
Fixes the following cases that the migration wasn't handling correctly:
* Variables whose names partially match the name of the variables being migrated. E.g. `$mat-blue-override`.
* Functions whose names partially match the names of function being migrated. E.g. `my-mat-palette`.
* Files where the top import comes from Material, but which have other imports further down in the file.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jun 15, 2021
@crisbeto crisbeto requested a review from jelbourn June 15, 2021 16:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2021
jelbourn
jelbourn approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 15, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 16, 2021
@wagnermaciel wagnermaciel merged commit 3c140fd into angular:master Jun 16, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @devversion @wagnermaciel