Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): improve color contrast in calendar header #23517

Merged
merged 1 commit into from Sep 13, 2021
Merged

fix(material/datepicker): improve color contrast in calendar header #23517

merged 1 commit into from Sep 13, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2021

Fixes that the color contrast of the calendar header's text was too low.

Fixes #23511.

@crisbeto
fix(material/datepicker): improve color contrast in calendar header
e7b9439 
Fixes that the color contrast of the calendar header's text was too low.

Fixes angular#23511.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Sep 2, 2021
@crisbeto crisbeto requested a review from zarend September 2, 2021 18:25
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2021
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 2, 2021
@crisbeto
Copy link
Member Author

crisbeto commented Sep 2, 2021

Caretaker note: this will generate some screenshot diffs in the calendar.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 2, 2021
@andrewseguin andrewseguin merged commit 1762da8 into angular:master Sep 13, 2021
andrewseguin pushed a commit that referenced this pull request Sep 13, 2021
@crisbeto @andrewseguin
fix(material/datepicker): improve color contrast in calendar header (#…
b487323 
…23517)

Fixes that the color contrast of the calendar header's text was too low.

Fixes #23511.

(cherry picked from commit 1762da8)
zarend
zarend reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zarend zarend zarend left review comments

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(datepicker): Header row cells have low color contrast ratio
4 participants
@crisbeto @zarend @mmalerba @andrewseguin