Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/a11y): complete input modality streams on destroy #23522

Merged
merged 1 commit into from Sep 10, 2021
Merged

fix(cdk/a11y): complete input modality streams on destroy #23522

merged 1 commit into from Sep 10, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 3, 2021

Fixes that we weren't completing the event streams from the InputModalityDetector when it is destroyed.

@crisbeto
fix(cdk/a11y): complete input modality streams on destroy
521297c 
Fixes that we weren't completing the event streams from the `InputModalityDetector` when it is destroyed.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 3, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2021
@andrewseguin andrewseguin merged commit a9886a1 into angular:master Sep 10, 2021
andrewseguin pushed a commit that referenced this pull request Sep 10, 2021
@crisbeto @andrewseguin
fix(cdk/a11y): complete input modality streams on destroy (#23522)
63f127b 
Fixes that we weren't completing the event streams from the `InputModalityDetector` when it is destroyed.

(cherry picked from commit a9886a1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zelliott zelliott zelliott approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @zelliott @devversion @andrewseguin