Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes #23559

Merged
merged 4 commits into from Sep 14, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 9, 2021

The MDC menu trigger had .mat-menu-trigger class because it was using
the same directive as the non-MDC menu. This PR refactors the trigger
and content directives to extend a common base class.

…asses

The MDC menu trigger had `.mat-menu-trigger` class because it was using
the same directive as the non-MDC menu. This PR refactors the trigger
and content directives to extend a common base class.
@mmalerba mmalerba requested a review from a team as a code owner September 9, 2021 19:39
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 9, 2021
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Sep 10, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2021
@andrewseguin andrewseguin merged commit 771afd9 into angular:master Sep 14, 2021
andrewseguin pushed a commit that referenced this pull request Sep 14, 2021
…asses (#23559)

* fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes

The MDC menu trigger had `.mat-menu-trigger` class because it was using
the same directive as the non-MDC menu. This PR refactors the trigger
and content directives to extend a common base class.

* fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes

* fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes

* fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes

(cherry picked from commit 771afd9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants