fix(material/tooltip): animations running when timeouts haven't elapsed #25699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state. These changes are an alternate take on the fix from angular#24652 which had to be reverted due to internal failures. Fixes angular#24614.
crisbeto
added
P2
crisbeto
requested review from
devversion,
josephperrott and
andrewseguin
as code owners
andrewseguin
approved these changes
Sep 26, 2022
crisbeto
added
target: major
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 26, 2022
…ed (angular#25699) After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state. These changes are an alternate take on the fix from angular#24652 which had to be reverted due to internal failures. Fixes angular#24614.
crisbeto
added a commit
that referenced
this pull request
Sep 26, 2022
…ed (#25699) (#25701) After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state. These changes are an alternate take on the fix from #24652 which had to be reverted due to internal failures. Fixes #24614.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 2, 2022
…hrough tooltip We ignore `mouseleave` events that go into the tooltip which meant that some animations weren't being cancelled correctly after the fix in angular#25699. These changes resolve the issue by skipping all animations if the tooltip isn't fully shown yet. Fixes angular#24614.
crisbeto
added a commit
that referenced
this pull request
Oct 3, 2022
…hrough tooltip (#25740) We ignore `mouseleave` events that go into the tooltip which meant that some animations weren't being cancelled correctly after the fix in #25699. These changes resolve the issue by skipping all animations if the tooltip isn't fully shown yet. Fixes #24614. (cherry picked from commit 6526277)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 5, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.2/14.2.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.2/14.2.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1423-wool-wombat-2022-09-28) [Compare Source](angular/components@14.2.2...14.2.3) ##### material | Commit | Type | Description | | -- | -- | -- | | [8c3d79156](angular/components@8c3d791) | fix | **bottom-sheet:** aria-modal not being set | | [7d314a87b](angular/components@7d314a8) | fix | **dialog:** aria-modal not being set | | [bc978445b](angular/components@bc97844) | fix | **stepper:** remove invalid aria attribute ([#​25644](angular/components#25644)) | | [a9d3bc580](angular/components@a9d3bc5) | fix | **tooltip:** animations running when timeouts haven't elapsed ([#​25699](angular/components#25699)) ([#​25701](angular/components#25701)) | #### Special Thanks James Skinner, Kristiyan Kostadinov and Paul Gschwendtner <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1568 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state.
These changes are an alternate take on the fix from #24652 which had to be reverted due to internal failures.
Fixes #24614.