Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: mat-dialog description not read by NVDA in Chrome #10591

Closed
diminutivesloop opened this issue Mar 27, 2018 · 7 comments
Closed

a11y: mat-dialog description not read by NVDA in Chrome #10591

diminutivesloop opened this issue Mar 27, 2018 · 7 comments
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) area: material/dialog G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@diminutivesloop
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When opening a Mat-Dialog via a screen-reader the specified description should be read in full before reading the dialog content or currently focused control. This happens as expected when using NVDA with the wai-aria modal dialog example.

What is the current behavior?

The dialog description is either not read at all or only read partially before NVDA abruptly switches to reading the auto-focused control.

What are the steps to reproduce?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material: 5.2.4
Chrome: 65.0.3325.181
NVDA: 2018.1

@diminutivesloop
Copy link
Author

Looks like this works correctly if you Disable the following NVDA settings under Preferences > Browse mode...

  • Use screen layout (when supported)
  • Say All on page load

Still not great that this doesn't work with the default settings especially when the wai-aria modal dialog example works fine regardless.

@mmalerba mmalerba added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue labels May 2, 2018
@crisbeto
Copy link
Member

CC @jelbourn since it's a little fuzzy how we should handle it on our end.

@jelbourn
Copy link
Member

@diminutivesloop could you clarify which example dialog you're referring to? It looks like the page you linked to has several as part of the example.

@diminutivesloop
Copy link
Author

@jelbourn Hmm... I checked the page and I'm not sure what you mean by several dialog examples. The demo I had in mind can be activated by clicking the Add Delivery Address button under the Modal Dialog Example. Does that help clarify?

@jelbourn
Copy link
Member

jelbourn commented Jun 5, 2018

@crisbeto that example dialog is doing the same thing as our's with focus behavior; I think there's something else in play that's causing it to read the dialog's label on open, but I'm not sure what exactly.

crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 15, 2018
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 15, 2018
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 15, 2018
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 15, 2018
…readers

Currently we focus the first focusable element inside a bottom sheet as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the bottom sheet content. These changes switch to focusing the bottom sheet container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the autoFocus option.

Relates to angular#10591.
jelbourn pushed a commit that referenced this issue Dec 18, 2018
…readers (#14534)

Currently we focus the first focusable element inside a bottom sheet as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the bottom sheet content. These changes switch to focusing the bottom sheet container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the autoFocus option.

Relates to #10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 13, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
…readers (angular#14534)

Currently we focus the first focusable element inside a bottom sheet as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the bottom sheet content. These changes switch to focusing the bottom sheet container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the autoFocus option.

Relates to angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 3, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 20, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 26, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 20, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes angular#10591.
jelbourn pushed a commit that referenced this issue Sep 6, 2019
Currently we focus the first focusable element inside a dialog as per the accessibility recommendations, however moving focus to the first item causes some screen readers not to read out the rest of the dialog content. These changes switch to focusing the dialog container by default which allows screen readers to read out everything. If users press tab, they'll land on the first tabbable element anyways. The old behavior can still be opted into via the `autoFocus` option.

Fixes #10591.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 26, 2020
…ders

Currently we focus the first focusable element inside a dialog as per the accessibility
recommendations, however moving focus to the first item causes some screen readers
not to read out the rest of the dialog content. These changes switch to focusing the
dialog container by default which allows screen readers to read out everything. If
users press tab, they'll land on the first tabbable element anyways. The old behavior
can still be opted into via the `autoFocus` option.

Fixes angular#10591.
@crisbeto
Copy link
Member

Should've been resolved by #23085.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: material/dialog G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants