fix(menu): scrollable menu not scrolled to top when opened for the first time #11859
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst time Fixes a menu with a scrollable content not being scrolled to the top when it's opened for the first time. The issue seems to come from the fact that the browser is thrown off by us moving focus while the menu is still animating. Fixes angular#11790.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Jun 26, 2018
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 18, 2018
…scrollable menu Originally in angular#11859 we introduced some logic that makes sure that the menu panel is always scrolled to the top when it's open. This works, but is janky, because the user can see the menu being scrolled down while it's animating. These changes move the logic, that reset the scroll position, from the `done` callback to `start`. Fixes angular#11790.
jelbourn
pushed a commit
that referenced
this pull request
Dec 19, 2018
…scrollable menu (#14190) Originally in #11859 we introduced some logic that makes sure that the menu panel is always scrolled to the top when it's open. This works, but is janky, because the user can see the menu being scrolled down while it's animating. These changes move the logic, that reset the scroll position, from the `done` callback to `start`. Fixes #11790.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…scrollable menu (angular#14190) Originally in angular#11859 we introduced some logic that makes sure that the menu panel is always scrolled to the top when it's open. This works, but is janky, because the user can see the menu being scrolled down while it's animating. These changes move the logic, that reset the scroll position, from the `done` callback to `start`. Fixes angular#11790.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a menu with scrollable content not being scrolled to the top when it's opened for the first time. The issue seems to come from the fact that the browser is thrown off by us moving focus while the menu is still animating.
Fixes #11790.