-
Notifications
You must be signed in to change notification settings - Fork 6.8k
icon-button ripple color problem #13232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
devversion
added a commit
to devversion/material2
that referenced
this issue
Sep 21, 2018
…buttons With angular@c3a8d0c, we already ensured that the text color is **inherited** in order to make sure that buttons without a background color are readable on various themed backgrounds (e.g. themed toolbars) This is a follow-up that ensures that the ripple color for such transparent buttons is contrasting to the background color (e.g. in themed toolbars). Fixes angular#13232
vivian-hu-zz
pushed a commit
that referenced
this issue
Nov 6, 2018
…buttons With c3a8d0c, we already ensured that the text color is **inherited** in order to make sure that buttons without a background color are readable on various themed backgrounds (e.g. themed toolbars) This is a follow-up that ensures that the ripple color for such transparent buttons is contrasting to the background color (e.g. in themed toolbars). Fixes #13232
devversion
added a commit
to devversion/material2
that referenced
this issue
Nov 8, 2018
…buttons With angular@c3a8d0c, we already ensured that the text color is **inherited** in order to make sure that buttons without a background color are readable on various themed backgrounds (e.g. themed toolbars) This is a follow-up that ensures that the ripple color for such transparent buttons is contrasting to the background color (e.g. in themed toolbars). Fixes angular#13232
vivian-hu-zz
pushed a commit
that referenced
this issue
Nov 8, 2018
…buttons (#13235) With c3a8d0c, we already ensured that the text color is **inherited** in order to make sure that buttons without a background color are readable on various themed backgrounds (e.g. themed toolbars) This is a follow-up that ensures that the ripple color for such transparent buttons is contrasting to the background color (e.g. in themed toolbars). Fixes #13232
vivian-hu-zz
pushed a commit
that referenced
this issue
Nov 12, 2018
…buttons (#13235) With c3a8d0c, we already ensured that the text color is **inherited** in order to make sure that buttons without a background color are readable on various themed backgrounds (e.g. themed toolbars) This is a follow-up that ensures that the ripple color for such transparent buttons is contrasting to the background color (e.g. in themed toolbars). Fixes #13232
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Bug, feature request, or proposal:
on a toolbar, the icon-button color follow the contrast color from the theme but the ripple do not.
What is the expected behavior?
on a toolbar, the icon-button ripple should follow the contrast color from the theme.
What is the current behavior?
on a toolbar, the icon-button ripple do not follow the contrast color from the theme.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-material2-issue-widrns
template
style
What is the use-case or motivation for changing an existing behavior?
Consistency between theme and components
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
test on :
Angular 6.1.7
Material 6.4.7
typescript 2.7.2
Windows 7
Chrome 69.0.3497.100
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: