fix(datepicker): don't allow clicks on disabled cells in year and multi-year views #13448
+2
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Oct 5, 2018
| @@ -3,7 +3,6 @@ | |||
| <tr><th class="mat-calendar-table-header-divider" colspan="4"></th></tr> | |||
| </thead> | |||
| <tbody mat-calendar-body | |||
| allowDisabledSelection="true" | |||
There was a problem hiding this comment.
@mmalerba this behavior seems pretty deliberate, but I'm not sure whether it makes sense. Also it only applies to mouse users, because you can't reach disabled cells with the keyboard.
There was a problem hiding this comment.
It looks like its been that way since the beginning, but I don't remember why I did it, and I agree that it doesn't really make sense. Can we also remove the allowDisabledSelection input from calendar body?
…ti-year views Doesn't allow users to click on disabled cells inside the calendar in the year and multi-year views. Fixes angular#13446.
crisbeto
force-pushed
the
13446/datepicker-disabled-cell-click
branch
from
74510ef to
80edd2e
Compare
mmalerba
approved these changes
Oct 5, 2018
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't allow users to click on disabled cells inside the calendar in the year and multi-year views.
Fixes #13446.