fix(form-field): outline gap not being recalculated on direction changes #13478
+42
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
form-field-outline-dir-change
branch
from
520b7ce to
634c9a1
Compare
crisbeto
force-pushed
the
form-field-outline-dir-change
branch
from
634c9a1 to
410e2e1
Compare
mmalerba
approved these changes
Oct 7, 2018
crisbeto
force-pushed
the
form-field-outline-dir-change
branch
from
410e2e1 to
244f180
Compare
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
form-field-outline-dir-change
branch
from
244f180 to
d5909be
Compare
Since some of the calculations for the outline gap depend on the direction, we need to re-run them of the direction changes.
crisbeto
force-pushed
the
form-field-outline-dir-change
branch
from
d5909be to
41b5f93
Compare
mmalerba
pushed a commit
that referenced
this pull request
Dec 10, 2018
…ges (#13478) Since some of the calculations for the outline gap depend on the direction, we need to re-run them of the direction changes.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ges (angular#13478) Since some of the calculations for the outline gap depend on the direction, we need to re-run them of the direction changes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some of the calculations for the outline gap depend on the direction, we need to re-run them of the direction changes.