fix(drag-drop): avoid generating elements with duplicate ids #13489
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| /** Creates a deep clone of an element. */ | ||
| function deepCloneNode(node: HTMLElement): HTMLElement { | ||
| const clone = node.cloneNode(true) as HTMLElement; | ||
| // Remove the `id` to avoid having multiple elements with the same id on the page. |
There was a problem hiding this comment.
Could this cause issues if the element is styled based on the id?
Should we at least document this in the md file for dragdrop?
There was a problem hiding this comment.
I'll add a note about it, but we've been doing this in the MatIconRegistry for a long time now and it hasn't come up.
crisbeto
force-pushed
the
drag-drop-duplicate-ids
branch
from
0a5edb5 to
0816d8e
Compare
crisbeto
added
target: patch
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
drag-drop-duplicate-ids
branch
from
0816d8e to
9311f64
Compare
crisbeto
force-pushed
the
drag-drop-duplicate-ids
branch
from
9311f64 to
8149766
Compare
If the consumer hasn't passed in a custom drag placeholder or preview, we clone the element that is being dragged. This can cause the DOM to have multiple elements with the same id.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
If the consumer hasn't passed in a custom drag placeholder or preview, we clone the element that is being dragged. This can cause the DOM to have multiple elements with the same id.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the consumer hasn't passed in a custom drag placeholder or preview, we clone the element that is being dragged. This can cause the DOM to have multiple elements with the same id.