fix(button-toggle): webkit tap highlight conflicting with ripples #13721
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that the `<mat-button-toggle-group>` still has `cursor: pointer`, the webkit tap highlight overlay will show up on touch devices. This causes a bad UX because the overlay covers the whole group while only an individual option has been touched. Additionally a ripple already shows up and now conflicts with the tap highlight overlay.
devversion
added
the
target: patch
googlebot
added
the
cla: yes
devversion
commented
Oct 21, 2018
| @@ -15,7 +15,6 @@ $mat-button-toggle-legacy-border-radius: 2px !default; | |||
| position: relative; | |||
| display: inline-flex; | |||
| flex-direction: row; | |||
| cursor: pointer; | |||
| white-space: nowrap; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
Note: I've kept white-space and overflow since they don't cause any issues, and otherwise we could potentially break apps (even though pretty rarely).
crisbeto
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Oct 23, 2018
…3721) Due to the fact that the `<mat-button-toggle-group>` still has `cursor: pointer`, the webkit tap highlight overlay will show up on touch devices. This causes a bad UX because the overlay covers the whole group while only an individual option has been touched. Additionally a ripple already shows up and now conflicts with the tap highlight overlay.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that the
<mat-button-toggle-group>still hascursor: pointer, the webkit tap highlight overlay will show up on touch devices.This causes a bad UX because the overlay covers the whole group while only an individual option has been touched. Additionally a ripple already shows up and now conflicts with the tap highlight overlay.