-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drag-drop): enable drag interactions when there is a drag handle #13780
Conversation
Also the commit message should be change to something like this:
|
4487ba1
to
b0dbb3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto passes presubmit, just needs rebase |
Hi @atscott! This PR has merge conflicts due to recent upstream merges. |
08f9a17
to
b3665eb
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
b3665eb
to
b0dbb3a
Compare
CLAs look good, thanks! |
34c63ba
to
b0dbb3a
Compare
Is there anything I need to do to resolve these or will that be done by whoever merges? |
@atscott you have to rebase the latest master into your branch. |
b0dbb3a
to
7c82b32
Compare
@crisbeto Done. |
@atscott looks like you need to rebase and resolve conflict again. |
If there is a drag handle, do not disable native drag events on the cdkDrag element. Fixes angular#13779.
7c82b32
to
89d0a32
Compare
@vivian-hu Done |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If there is a drag handle, do not disable native drag events on the cdkDrag
element.