fix: workaround for es2015 inheritance not always working #13834
+51
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the inherited `ctorParameters` can be either a static array or a function that returns an array, the workaround that landed with e9103a6 does not fully solve the issue, which developers experience when using Angular Material with ES2015. This improves the workaround and ensures that it handles both scenarios properly. Also the workaround has been moved into a separate function in order to remove code duplication. This should also make it easier to delete the workaround if we need to.
devversion
added
the
target: patch
devversion
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
added
the
P2
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Oct 30, 2018
…gular#13834)" This reverts commit a22a9fa. This change caused a new issue where Closure Compiler was not able to do dead-code elimination due to the function call with unknown side effects.
jelbourn
added a commit
that referenced
this pull request
Oct 30, 2018
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
) Since the inherited `ctorParameters` can be either a static array or a function that returns an array, the workaround that landed with e9103a6 does not fully solve the issue, which developers experience when using Angular Material with ES2015. This improves the workaround and ensures that it handles both scenarios properly. Also the workaround has been moved into a separate function in order to remove code duplication. This should also make it easier to delete the workaround if we need to.
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
…gular#13834)" (angular#13868) This reverts commit a22a9fa. This change caused a new issue where Closure Compiler was not able to do dead-code elimination due to the function call with unknown side effects.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Since the inherited `ctorParameters` can be either a static array or a function that returns an array, the workaround that landed with e9103a6 does not fully solve the issue, which developers experience when using Angular Material with ES2015. This improves the workaround and ensures that it handles both scenarios properly. Also the workaround has been moved into a separate function in order to remove code duplication. This should also make it easier to delete the workaround if we need to.
jelbourn
added a commit
that referenced
this pull request
Nov 6, 2018
|
Thanks for this @devversion !!! Just got everything upgraded to the latest 7.x releases(material, angular core, and flex-layout). Sadly running es5 due to flex-layout pending upgrade but still happy to be upgraded. Nice to see everything loading on latest versions :) I know this was a lot of work on your end. |
|
Hi @epelc, thanks for the feedback. Unfortunately we had to revert the latest workaround again because it broke Google closure compiler, so Material should no longer work with ES2015 latest version. We basically delegated the issue to angular/angular#27267 |
|
@devversion unfortunate but good to know! At least I'm back on es5 for now with the help of |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the inherited
ctorParameterscan be either a static array or a function that returns an array, the workaround that landed with e9103a6 does not fully solve the issue which developers experience when using Angular Material with ES2015. This improves the workaround and ensures that it handles both scenarios properly.Also the workaround has been moved into a separate function in order to remove code duplication. This should also make it easier to delete the workaround if we need to.
See #12760 for more details about the whole issues.
Note: I've tested thoroughly and went through the reflection capabilities of
@angular/core. This should finally resolve the issue completely and it's just a matter of time until the issue is fixed upstream (there are various issues filed; see referenced issues in #12760)Thanks to @epelc for finding this.