Skip to content

matRippleDisabled at mat-datepicker-toggle #13986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oky1 opened this issue Nov 5, 2018 · 1 comment · Fixed by #13997
Closed

matRippleDisabled at mat-datepicker-toggle #13986

oky1 opened this issue Nov 5, 2018 · 1 comment · Fixed by #13997
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@oky1
Copy link

oky1 commented Nov 5, 2018 •
edited
Loading

Bug, feature request, or proposal:

matRippleDisabled at mat-datepicker-toggle

What is the expected behavior?

matRippleDisabled should disable ripple on button

What is the current behavior?

Not disabled ripple on button

What are the steps to reproduce?

Add matRippleDisabled at mat-datepicker-toggle component

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Ang 7.0, Crome 0.0.3538.77, AngMaterial 7.0
@crisbeto crisbeto self-assigned this Nov 5, 2018
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Nov 5, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 5, 2018
@crisbeto
fix(datepicker): unable to disable ripple on datepicker toggle
52590b7 
Allows for the ripple on the datepicker toggle to be disabled.

Fixes angular#13986.
@crisbeto crisbeto mentioned this issue Nov 5, 2018
Merged
vivian-hu-zz pushed a commit that referenced this issue Nov 6, 2018
@crisbeto
fix(datepicker): unable to disable ripple on datepicker toggle
82f30ca 
Allows for the ripple on the datepicker toggle to be disabled.

Fixes #13986.
vivian-hu-zz pushed a commit that referenced this issue Nov 7, 2018
@crisbeto @vivian-hu-zz
fix(datepicker): unable to disable ripple on datepicker toggle (#13997)
31bffb3 
Allows for the ripple on the datepicker toggle to be disabled.

Fixes #13986.
vivian-hu-zz pushed a commit that referenced this issue Nov 12, 2018
@crisbeto
fix(datepicker): unable to disable ripple on datepicker toggle (#13997)
2fb58ab 
Allows for the ripple on the datepicker toggle to be disabled.

Fixes #13986.
@oky1 oky1 mentioned this issue Jan 31, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datepicker): unable to disable ripple on datepicker toggle crisbeto/material2
2 participants
@crisbeto @oky1