Skip to content

fix(button-toggle): not forwarding focus to underlying control #14001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix(button-toggle): not forwarding focus to underlying control #14001

merged 1 commit into from
Nov 7, 2018
+19 −3

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 6, 2018

Fixes the button toggle host element not being able to receive focus which means that it can't be used with the focus trap directives. Also fixes that when it does receive focus, it won't forward it to the underlying button element.

@crisbeto
fix(button-toggle): not forwarding focus to underlying control

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
GPG key ID: 6C654787275A64F1
Expired
Verified
Learn about vigilant mode
fdd5e56 
Fixes the button toggle host element not being able to receive focus which means that it can't be used with the focus trap directives. Also fixes that when it does receive focus, it won't forward it to the underlying `button` element.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Nov 6, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner November 6, 2018 06:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2018
jelbourn
jelbourn approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2018
@vivian-hu-zz vivian-hu-zz merged commit 81f8fb9 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
fix(button-toggle): not forwarding focus to underlying control (#14001)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
GPG key ID: 6C654787275A64F1
Expired
Verified
Learn about vigilant mode
b7be573 
Fixes the button toggle host element not being able to receive focus which means that it can't be used with the focus trap directives. Also fixes that when it does receive focus, it won't forward it to the underlying `button` element.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz