Skip to content

fix(datepicker): toggle not forwarding focus to underlying button #14020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

fix(datepicker): toggle not forwarding focus to underlying button #14020

merged 1 commit into from
Nov 10, 2018
+26 −3

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 7, 2018

Fixes the datepicker toggle not being focusable which prevents people from using the focus trap directives, and not forwarding focus to its underlying button element.

@crisbeto
fix(datepicker): toggle not forwarding focus to underlying button
012fe6a 
Fixes the datepicker toggle not being focusable which prevents people from using the focus trap directives, and not forwarding focus to its underlying `button` element.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Nov 7, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner November 7, 2018 07:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2018
jelbourn
jelbourn approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 7, 2018
@vivian-hu-zz vivian-hu-zz merged commit b1d4b42 into angular:master Nov 10, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
fix(datepicker): toggle not forwarding focus to underlying button (#1…
723d7f5 
…4020)

Fixes the datepicker toggle not being focusable which prevents people from using the focus trap directives, and not forwarding focus to its underlying `button` element.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

@mmalerba mmalerba

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz