Skip to content

LiveAnnouncer wrong instanciated and breaking depending Components #14077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jan-moxter opened this issue Nov 10, 2018 · 1 comment · Fixed by #14078
Closed

LiveAnnouncer wrong instanciated and breaking depending Components #14077

jan-moxter opened this issue Nov 10, 2018 · 1 comment · Fixed by #14078
Assignees
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@jan-moxter
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Not breaking other Components

What is the current behavior?

What are the steps to reproduce?

Providing a StackBlitz reproduction is the best way to share your issue.

StackBlitz starter: https://goo.gl/wwnhMV

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 7

Is there anything else we should know?

In https://github.com/angular/material2/blob/master/src/cdk/a11y/live-announcer/live-announcer.ts

The factory does call the constructor with the wrong argument sequence: _document, ngZone

export function LIVE_ANNOUNCER_PROVIDER_FACTORY(
parentDispatcher: LiveAnnouncer, liveElement: any, _document: any, ngZone: NgZone) {
return parentDispatcher || new LiveAnnouncer(liveElement, _document, ngZone);
}

but: ngZone, _document

constructor(
@optional() @Inject(LIVE_ANNOUNCER_ELEMENT_TOKEN) elementToken: any,
private _ngZone: NgZone,
@Inject(DOCUMENT) _document: any) {

@crisbeto crisbeto self-assigned this Nov 10, 2018
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Nov 10, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 10, 2018
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments.

Fixes angular#14077.
andrewseguin pushed a commit that referenced this issue Nov 14, 2018
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments.

Fixes #14077.
josephperrott pushed a commit that referenced this issue Nov 19, 2018
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments.

Fixes #14077.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants