We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug
Not breaking other Components
Providing a StackBlitz reproduction is the best way to share your issue. StackBlitz starter: https://goo.gl/wwnhMV
Angular 7
In https://github.com/angular/material2/blob/master/src/cdk/a11y/live-announcer/live-announcer.ts
The factory does call the constructor with the wrong argument sequence: _document, ngZone
export function LIVE_ANNOUNCER_PROVIDER_FACTORY( parentDispatcher: LiveAnnouncer, liveElement: any, _document: any, ngZone: NgZone) { return parentDispatcher || new LiveAnnouncer(liveElement, _document, ngZone); }
but: ngZone, _document
constructor( @optional() @Inject(LIVE_ANNOUNCER_ELEMENT_TOKEN) elementToken: any, private _ngZone: NgZone, @Inject(DOCUMENT) _document: any) {
The text was updated successfully, but these errors were encountered:
fix(a11y): wrong order of constructor arguments in provider
a3ca037
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments. Fixes angular#14077.
fix(a11y): wrong order of constructor arguments in provider (#14078)
2fcf9e7
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments. Fixes #14077.
f6a7a89
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
Sorry, something went wrong.
crisbeto
Successfully merging a pull request may close this issue.
Bug, feature request, or proposal:
Bug
What is the expected behavior?
Not breaking other Components
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 7
Is there anything else we should know?
In https://github.com/angular/material2/blob/master/src/cdk/a11y/live-announcer/live-announcer.ts
The factory does call the constructor with the wrong argument sequence: _document, ngZone
export function LIVE_ANNOUNCER_PROVIDER_FACTORY(
parentDispatcher: LiveAnnouncer, liveElement: any, _document: any, ngZone: NgZone) {
return parentDispatcher || new LiveAnnouncer(liveElement, _document, ngZone);
}
but: ngZone, _document
constructor(
@optional() @Inject(LIVE_ANNOUNCER_ELEMENT_TOKEN) elementToken: any,
private _ngZone: NgZone,
@Inject(DOCUMENT) _document: any) {
The text was updated successfully, but these errors were encountered: