Skip to content

fix(chips): not updating keyboard controls if direction changes #14080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix(chips): not updating keyboard controls if direction changes #14080

merged 1 commit into from
Nov 14, 2018
+56 −3

Conversation

crisbeto
Copy link
Member

Fixes the chip list not updating the direction of its keyboard controls, if the direction changes after the component has been initialized.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 10, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner November 10, 2018 08:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 10, 2018
@crisbeto crisbeto force-pushed the chip-list-dir-changes branch 2 times, most recently from 5f275fd to d2d1a2a Compare November 10, 2018 09:15
@crisbeto
fix(chips): not updating keyboard controls if direction changes

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
GPG key ID: 6C654787275A64F1
Expired
Verified
Learn about vigilant mode
d2d1a2a 
Fixes the chip list not updating the direction of its keyboard controls, if the direction changes after the component has been initialized.
jelbourn
jelbourn approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 12, 2018
@andrewseguin andrewseguin merged commit 1ffa1fc into angular:master Nov 14, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
@crisbeto @josephperrott
fix(chips): not updating keyboard controls if direction changes (#14080)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
GPG key ID: 6C654787275A64F1
Expired
Verified
Learn about vigilant mode
bd15024 
Fixes the chip list not updating the direction of its keyboard controls, if the direction changes after the component has been initialized.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin