fix(a11y): inconsistent runtime value for ListKeyManager.activeItem #14154
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
diicar
reviewed
Nov 15, 2018
|
|
||
| this._activeItemIndex = index; | ||
| this._activeItem = itemArray[index]; | ||
| this._activeItem = typeof activeItem === 'undefined' ? null : activeItem; |
There was a problem hiding this comment.
this._activeItem = activeItem == null ? null : activeItem; is shorter no ?
crisbeto
force-pushed
the
14152/list-key-manager-active-item
branch
from
3410334 to
4c7409d
Compare
jelbourn
approved these changes
Nov 15, 2018
|
|
||
| this._activeItemIndex = index; | ||
| this._activeItem = itemArray[index]; | ||
| this._activeItem = activeItem == null ? null : activeItem; |
There was a problem hiding this comment.
Add a comment like
// Explicitly check for `null` and `undefined` because other falsy values are valid.
The `activeItem` is currently typed to `T | null`, however on init and when assigning incorrect values, the `activeItem` will actually be `undefined` at runtime. These changes add some logic to make sure that the value is consistent with its type. Fixes angular#14152.
crisbeto
force-pushed
the
14152/list-key-manager-active-item
branch
from
4c7409d to
119005e
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ngular#14154) The `activeItem` is currently typed to `T | null`, however on init and when assigning incorrect values, the `activeItem` will actually be `undefined` at runtime. These changes add some logic to make sure that the value is consistent with its type. Fixes angular#14152.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
activeItemis currently typed toT | null, however on init and when assigning incorrect values, theactiveItemwill actually beundefinedat runtime. These changes add some logic to make sure that the value is consistent with its type.Fixes #14152.