feat(drag-drop): add the ability to constrain dragging to an element #14242
+164
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
changed the title
crisbeto
force-pushed
the
14211/drag-drop-boundry
branch
from
8aa7719 to
aa7b826
Compare
devversion
reviewed
Nov 23, 2018
src/cdk/drag-drop/drag.ts
Outdated
| * be constrained. Matching starts from the element's parent and goes up the DOM until a matching | ||
| * element has been found. | ||
| */ | ||
| @Input('cdkDragBoundry') boundryElementSelector: string; |
There was a problem hiding this comment.
Is it really called boundry? Please correct me if I'am wrong, but I thought it's boundary
There was a problem hiding this comment.
It's boundary, good catch.
crisbeto
force-pushed
the
14211/drag-drop-boundry
branch
2 times, most recently
from
3900385 to
40d2540
Compare
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
jelbourn
approved these changes
Nov 29, 2018
src/cdk/drag-drop/drag.spec.ts
Outdated
| @@ -545,6 +546,17 @@ describe('CdkDrag', () => { | |||
| expect(fixture.componentInstance.endedSpy).toHaveBeenCalledTimes(1); | |||
| })); | |||
|
|
|||
| it('should allow for dragging to be constrained to an elemnet', fakeAsync(() => { | |||
crisbeto
force-pushed
the
14211/drag-drop-boundry
branch
from
40d2540 to
e976add
Compare
crisbeto
added
action: merge
Adds the `cdkDragBoundary` input that allows for people to constrain the dragging of an element to another element. Fixes angular#14211.
crisbeto
force-pushed
the
14211/drag-drop-boundry
branch
from
e976add to
6574c2f
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ngular#14242) Adds the `cdkDragBoundary` input that allows for people to constrain the dragging of an element to another element. Fixes angular#14211.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
cdkDragBoundaryinput that allows for people to constrain the dragging of an element to another element.Fixes #14211.