Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-field): native select label floating incorrectly when invalid value is set #14263

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

crisbeto
Copy link
Member

Fixes the label for a form field with a native select floating when it isn't supposed to, if a value that isn't in the options list is assigned.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 25, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner November 25, 2018 16:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 25, 2018
@ngbot
Copy link

ngbot bot commented Nov 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Nov 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

…d value is set

Fixes the label for a form field with a native select floating when it isn't supposed to, if a value that isn't in the options list is assigned.
@crisbeto crisbeto force-pushed the select-blank-invalid branch from 6e1a1bf to 7579428 Compare November 27, 2018 17:54
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2018
@mmalerba mmalerba merged commit 9c65c87 into angular:master Dec 4, 2018
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
…d value is set (#14263)

Fixes the label for a form field with a native select floating when it isn't supposed to, if a value that isn't in the options list is assigned.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…d value is set (angular#14263)

Fixes the label for a form field with a native select floating when it isn't supposed to, if a value that isn't in the options list is assigned.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants