Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] Step header is still in error when hasError is set to false #14333

Closed
eprevot opened this issue Nov 30, 2018 · 1 comment · Fixed by #14337
Closed

[Stepper] Step header is still in error when hasError is set to false #14333

eprevot opened this issue Nov 30, 2018 · 1 comment · Fixed by #14337
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@eprevot
Copy link

eprevot commented Nov 30, 2018

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When hasError="false", the step header should show a normal label even if the step is interacted and invalid

What is the current behavior?

When hasError="false", the step header shows an error state label if the step is interacted and invalid

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-gtxr8x
Go to step 2 without filling the step 1 required input : step 1 label shows error whereas it's set to hasError="false"

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 7.1.0
Angular 7.1.1

Is there anything else we should know?

Behaviour is ok with hasError = true
If you set hasError="true" on a mat-step the step will always be styled as a step in error (even if it has not been interacted or is valid)
@crisbeto crisbeto self-assigned this Nov 30, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Nov 30, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 30, 2018
@crisbeto
fix(stepper): ignoring custom falsy value for hasError
61319fe 
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes angular#14333.
@crisbeto crisbeto mentioned this issue Nov 30, 2018
Merged
mmalerba pushed a commit that referenced this issue Dec 3, 2018
@crisbeto @mmalerba
fix(stepper): ignoring custom falsy value for hasError (#14337)
7fac915 
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes #14333.
mmalerba pushed a commit that referenced this issue Dec 10, 2018
@crisbeto @mmalerba
fix(stepper): ignoring custom falsy value for hasError (#14337)
54e58c0 
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes #14333.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
@crisbeto @josephperrott
fix(stepper): ignoring custom falsy value for hasError (angular#14337)
f3794e8 
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes angular#14333.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stepper): ignoring custom falsy value for hasError crisbeto/material2
2 participants
@crisbeto @eprevot