Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): ignoring custom falsy value for hasError #14337

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

crisbeto
Copy link
Member

The hasError input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes #14333.

The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes angular#14333.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 30, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner November 30, 2018 19:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 30, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2018
@mmalerba mmalerba merged commit 7fac915 into angular:master Dec 3, 2018
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes #14333.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.
These changes also fix one of the test fixtures where an error was being swallowed silently.

Fixes angular#14333.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stepper] Step header is still in error when hasError is set to false
3 participants