Skip to content

bug(drag-drop): Safari selects text on drag #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philmtd opened this issue Dec 6, 2018 · 3 comments · Fixed by #14405
Closed

bug(drag-drop): Safari selects text on drag #14403

philmtd opened this issue Dec 6, 2018 · 3 comments · Fixed by #14405
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@philmtd
Copy link

philmtd commented Dec 6, 2018

What is the expected behavior?

Safari (or any browser) should not select text when starting to drag an item.

What is the current behavior?

When starting to drag an item in a drop list, Safari selects the text that is near to the dragged item.

What are the steps to reproduce?

Stackblitz: https://stackblitz.com/edit/angular-material2-issue-b6tvka
Switch the versions of cdk and material to 7.1.0 to see the previous and correct behaviour.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

  • Safari 12.0.1 (but probably not only this version)
  • CDK & Material 7.1.1

Is there anything else we should know?

I tried it with Chrome and Firefox on macOS and the bug did not appear there, so it is probably exclusive to Safari. This bug was introduced in the 7.1.1 release. Downgrading to 7.1.0 fixes this behaviour. This can easily be verified using the stackblitz example from above.

@philmtd philmtd changed the title drag-drop: Safari selects text on drag bug(drag-drop): Safari selects text on drag Dec 6, 2018
@crisbeto
Copy link
Member

crisbeto commented Dec 6, 2018

This is most likely due to 1c74b03. We had to remove our previous workaround for Safari, because it had a lot of performance implications on pages with a lot of elements.

@crisbeto crisbeto self-assigned this Dec 6, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Dec 6, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 6, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
Fixes being able to select text while dragging an item on Safari.

Fixes angular#14403.
@philmtd
Copy link
Author

philmtd commented Dec 6, 2018

I also suspected that. Thanks for fixing it so fast :)

crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 7, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
Fixes being able to select text while dragging an item on Safari.

Fixes angular#14403.
vivian-hu-zz pushed a commit that referenced this issue Dec 12, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
Fixes being able to select text while dragging an item on Safari.

Fixes #14403.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
…lar#14405)

Fixes being able to select text while dragging an item on Safari.

Fixes angular#14403.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants