Skip to content

fix(schematics): drag-drop schematic two consecutive commas #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Similar to dd6065c, we should also fix the issue for the drag-drop schematic.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Similar to angular@dd6065c#diff-0971fc26ab0589f93c1344ce29da61e4, we should also fix the issue for the drag-drop schematic.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 10, 2018
@devversion devversion requested a review from jelbourn as a code owner December 10, 2018 17:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@vivian-hu-zz vivian-hu-zz merged commit 35fd998 into angular:master Dec 14, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants