fix(drag-drop): unable to stop dragging after quick double click #14506
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 13, 2018
| @@ -495,7 +495,7 @@ export class DragRef<T = any> { | |||
|
|
|||
| /** Handler that is invoked when the user lifts their pointer up, after initiating a drag. */ | |||
| private _pointerUp = (event: MouseEvent | TouchEvent) => { | |||
| if (!this.isDragging()) { | |||
| if (!this._dragDropRegistry.isDragging(this)) { | |||
There was a problem hiding this comment.
Add a comment that explains why this is not using this.isDragging()?
crisbeto
force-pushed
the
drag-drop-double-click
branch
from
eb36d1e to
209abe7
Compare
Seems to be something that regressed while we were doing the recent refactor. When starting a drag after a quick double-click sequence, the user can't stop dragging.
crisbeto
force-pushed
the
drag-drop-double-click
branch
from
209abe7 to
789f17b
Compare
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ular#14506) Seems to be something that regressed while we were doing the recent refactor. When starting a drag after a quick double-click sequence, the user can't stop dragging.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be something that regressed while we were doing the recent refactor. When starting a drag after a quick double-click sequence, the user can't stop dragging.