fix(text-field): add fallback for browsers that don't support requestAnimationFrame #14519
+26
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AnimationFrame Currently we've got a block in the autosize textarea that depends on `requestAnimationFrame`, however it won't run if it isn't supported, which means that the fix it's applying won't run on some browsers. These changes add a fallback via `setTimeout`.
googlebot
added
the
cla: yes
|
What browsers don't support requestAnimationFrame? |
|
IIRC it’s some of the older IEs and Angular Universal. I did it it primarily for consistency since it’s what we do everywhere we use requestAnimationFrame, but it’s fine if you think that we should close this one. |
|
We should find out if Angular Universal still doesn't support this, I would think it does. And I know IE11+ supports it, so we don't have to worry there |
|
I just tried logging out |
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Dec 18, 2018
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…AnimationFrame (angular#14519) Currently we've got a block in the autosize textarea that depends on `requestAnimationFrame`, however it won't run if it isn't supported, which means that the fix it's applying won't run on some browsers. These changes add a fallback via `setTimeout`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we've got a block in the autosize textarea that depends on
requestAnimationFrame, however it won't run if it isn't supported, which means that the fix it's applying won't run on some browsers. These changes add a fallback viasetTimeout.