fix(select): announce value changes with arrow keys while closed #14540
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
We support the functionality from the native select where people can change the value while the dropdown is closed via the arrow keys, however for screen reader users there is no feedback that the value has changed. These changes announce the select value if it changes.
crisbeto
force-pushed
the
select-announce-closed-changes
branch
from
bc99058 to
2be305c
Compare
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ular#14540) We support the functionality from the native select where people can change the value while the dropdown is closed via the arrow keys, however for screen reader users there is no feedback that the value has changed. These changes announce the select value if it changes.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 12, 2019
…closed select Fixes `mat-select` throwing an error when the user reaches a reset option using the arrow keys on a closed select. Seems to be due to a missing null check in the changes from angular#14540. Fixes angular#15159.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support the functionality from the native select where people can change the value while the dropdown is closed via the arrow keys, however for screen reader users there is no feedback that the value has changed. These changes announce the select value if it changes.