Skip to content

material tabs broken animation on"rtl" mode with left and right button clicks #14689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kordeviant opened this issue Jan 1, 2019 · 2 comments · Fixed by #14690
Closed

material tabs broken animation on"rtl" mode with left and right button clicks #14689

kordeviant opened this issue Jan 1, 2019 · 2 comments · Fixed by #14690
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@kordeviant
Copy link

What is the expected behavior?

smooth animation when left and right buttons get clicked

What is the current behavior?

laggy and broken with jumps and sudden movements.

What are the steps to reproduce?

simple example with rtl and small width:
https://stackblitz.com/edit/material-tabs-rtl-problem

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

7.2.0
@crisbeto
Copy link
Member

crisbeto commented Jan 1, 2019 •
edited
Loading

I tracked the issue down to this line, however removing it will reintroduce a bug on IE.

@crisbeto crisbeto self-assigned this Jan 1, 2019
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jan 1, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 1, 2019
@crisbeto
fix(tabs): pagination not working correctly on chrome in rtl mode

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c991bf8 
In angular#13223 we added some code that resets the scroll position of the tab header, in order to fix a bug on IE and Edge. The changes seem to have introduced an issue on newer Chrome versions in RTL mode where the transform gets negated and the header content doesn't move. These changes scope the fix only to IE and Edge.

Fixes angular#14689.
@crisbeto crisbeto mentioned this issue Jan 1, 2019
Merged
vivian-hu-zz pushed a commit that referenced this issue Jan 15, 2019
@crisbeto @vivian-hu-zz
fix(tabs): pagination not working correctly on chrome in rtl mode (#1…
220e6b2 
…4690)

In #13223 we added some code that resets the scroll position of the tab header, in order to fix a bug on IE and Edge. The changes seem to have introduced an issue on newer Chrome versions in RTL mode where the transform gets negated and the header content doesn't move. These changes scope the fix only to IE and Edge.

Fixes #14689.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto
fix(tabs): pagination not working correctly on chrome in rtl mode (an…
ebe08b2 
…gular#14690)

In angular#13223 we added some code that resets the scroll position of the tab header, in order to fix a bug on IE and Edge. The changes seem to have introduced an issue on newer Chrome versions in RTL mode where the transform gets negated and the header content doesn't move. These changes scope the fix only to IE and Edge.

Fixes angular#14689.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto
fix(tabs): pagination not working correctly on chrome in rtl mode (an…
ba3bfe9 
…gular#14690)

In angular#13223 we added some code that resets the scroll position of the tab header, in order to fix a bug on IE and Edge. The changes seem to have introduced an issue on newer Chrome versions in RTL mode where the transform gets negated and the header content doesn't move. These changes scope the fix only to IE and Edge.

Fixes angular#14689.
vivian-hu-zz pushed a commit that referenced this issue Jan 18, 2019
@crisbeto
fix(tabs): pagination not working correctly on chrome in rtl mode (#1…
e721664 
…4690)

In #13223 we added some code that resets the scroll position of the tab header, in order to fix a bug on IE and Edge. The changes seem to have introduced an issue on newer Chrome versions in RTL mode where the transform gets negated and the header content doesn't move. These changes scope the fix only to IE and Edge.

Fixes #14689.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): pagination not working correctly on chrome in rtl mode crisbeto/material2
2 participants
@crisbeto @kordeviant