Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the availability to disable the close of a bottomSheet programatically once is opened. #14708

Closed
mhosman opened this issue Jan 3, 2019 · 1 comment · Fixed by #14711
Closed

Add the availability to disable the close of a bottomSheet programatically once is opened. #14708

mhosman opened this issue Jan 3, 2019 · 1 comment · Fixed by #14711
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@mhosman
Copy link

mhosman commented Jan 3, 2019 •
edited
Loading

Add the availability to disable the close of a bottomSheet programatically once is opened (like in dialogs).
@crisbeto crisbeto self-assigned this Jan 3, 2019
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Jan 3, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 3, 2019
@crisbeto
fix(bottom-sheet): allow disableClose to be updated after opened
650832c 
Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`.

Fixes angular#14708.
@crisbeto crisbeto mentioned this issue Jan 3, 2019
Merged
vivian-hu-zz pushed a commit that referenced this issue Jan 16, 2019
@crisbeto @vivian-hu-zz
fix(bottom-sheet): allow disableClose to be updated after opened (#14711
3d3179f 
)

Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`.

Fixes #14708.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto @s2-abdo
fix(bottom-sheet): allow disableClose to be updated after opened (ang…
832f75a 
…ular#14711)

Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`.

Fixes angular#14708.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto @s2-abdo
fix(bottom-sheet): allow disableClose to be updated after opened (ang…
8390bbb 
…ular#14711)

Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`.

Fixes angular#14708.
vivian-hu-zz pushed a commit that referenced this issue Jan 18, 2019
@crisbeto
fix(bottom-sheet): allow disableClose to be updated after opened (#14711
c11e968 
)

Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`.

Fixes #14708.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bottom-sheet): allow disableClose to be updated after opened crisbeto/material2
2 participants
@crisbeto @mhosman