fix(bottom-sheet): allow disableClose to be updated after opened #14711
Conversation
Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`. Fixes angular#14708.
googlebot
added
the
cla: yes
| @@ -42,6 +45,7 @@ export class MatBottomSheetRef<T = any, R = any> { | |||
| // @breaking-change 8.0.0 `_location` parameter to be removed. | |||
| _location?: Location) { | |||
| this.containerInstance = containerInstance; | |||
| this.disableClose = containerInstance.bottomSheetConfig.disableClose; | |||
There was a problem hiding this comment.
Will this potentially change the behavior since you are setting the value in the class instead of reading it from the object at the time of the check?
There was a problem hiding this comment.
It won't change the behavior, because the old approach only read it once on init.
There was a problem hiding this comment.
Ahh, yes because it set up the subscription based on that. Makes sense.
| @@ -42,6 +45,7 @@ export class MatBottomSheetRef<T = any, R = any> { | |||
| // @breaking-change 8.0.0 `_location` parameter to be removed. | |||
| _location?: Location) { | |||
| this.containerInstance = containerInstance; | |||
| this.disableClose = containerInstance.bottomSheetConfig.disableClose; | |||
There was a problem hiding this comment.
Ahh, yes because it set up the subscription based on that. Makes sense.
josephperrott
added
pr: lgtm
action: merge
…ular#14711) Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`. Fixes angular#14708.
…ular#14711) Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`. Fixes angular#14708.
) Allows for the `disableClose` value of a bottom sheet to be updated after it has been opened, similarly to `MatDialog`. Fixes #14708.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for the
disableClosevalue of a bottom sheet to be updated after it has been opened, similarly toMatDialog.Fixes #14708.