Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): set class when item or list is disabled #14769

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 9, 2019

Sets a class on disabled CdkDrag and CdkDropList to make it easier to style the elements while they're disabled.

Fixes #14760.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 9, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner January 9, 2019 18:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@ngbot
Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Sets a class on disabled `CdkDrag` and `CdkDropList` to make it easier to style the elements while they're disabled.

Fixes angular#14760.
@crisbeto crisbeto force-pushed the 14760/drag-drop-disabled-class branch from 7381764 to 6fe55b9 Compare January 29, 2019 21:35
@jelbourn jelbourn merged commit 456a089 into angular:master Feb 7, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
Sets a class on disabled `CdkDrag` and `CdkDropList` to make it easier to style the elements while they're disabled.

Fixes #14760.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles for disabled Dragging element
3 participants