Skip to content

fix(stepper): ensure step state is not minified #14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2019
Merged

fix(stepper): ensure step state is not minified #14933

merged 4 commits into from
Jan 25, 2019
+23 −43

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jan 23, 2019 •
edited
Loading

Fixes #14931

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue labels Jan 23, 2019
@mmalerba mmalerba requested review from jelbourn and crisbeto January 23, 2019 21:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 23, 2019
jelbourn
jelbourn approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 23, 2019
crisbeto
crisbeto reviewed Jan 23, 2019
View reviewed changes
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Jan 23, 2019
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 23, 2019
crisbeto
crisbeto approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the reformatted imports will probably throw a lint error.

@mmalerba
Copy link
Contributor Author

Ah whoops, been trying out using vscode instead of webstorm and I don't think I got all the settings right. I'll fix the formatting things

@mmalerba
fix(stepper): ensure step state is not minified
3bc1ab2
@mmalerba
address feedback
ce7bffb
@mmalerba
update api goldens

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f95e396
@mmalerba
fix number state
9c23924
@andrewseguin andrewseguin merged commit e7b0e40 into angular:master Jan 25, 2019
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Jan 25, 2019
andrewseguin pushed a commit that referenced this pull request Jan 25, 2019
@mmalerba @andrewseguin
fix(stepper): ensure step state is not minified (#14933)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1fab7bb 
* fix(stepper): ensure step state is not minified

* update api goldens

* address feedback

* fix number state
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

@crisbeto crisbeto

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(stepper): step states getting accidentally minified
5 participants
@mmalerba @jelbourn @crisbeto @googlebot @andrewseguin