fix(examples): fix form-field custom control disabled input
#14957
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes form-field custom control example and guide so as not to attempt to use the `disabled` attribute on an input element that has a reactive form directive. see: https://github.com/angular/angular/blob/e2c98fbe11272295c3827b0e54f859d283cd32bf/packages/forms/src/directives/reactive_errors.ts#L64
googlebot
added
the
cla: yes
crisbeto
reviewed
Jan 26, 2019
| get disabled(): boolean { return this._disabled; } | ||
| set disabled(value: boolean) { | ||
| this._disabled = coerceBooleanProperty(value); | ||
| this._disabled ? this.parts.disable() : this.parts.enable(); |
There was a problem hiding this comment.
Should this be added to the final result in form-field-custom-control-example.ts as well?
There was a problem hiding this comment.
@crisbeto Yes, this PR amends the guide and example to match. Thanks
There was a problem hiding this comment.
Ah, I must've missed it the first time around.
crisbeto
approved these changes
Jan 26, 2019
| get disabled(): boolean { return this._disabled; } | ||
| set disabled(value: boolean) { | ||
| this._disabled = coerceBooleanProperty(value); | ||
| this._disabled ? this.parts.disable() : this.parts.enable(); |
There was a problem hiding this comment.
Ah, I must've missed it the first time around.
crisbeto
added
pr: lgtm
docs
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2019
* fixes form-field custom control example and guide so as not to attempt to use the `disabled` attribute on an input element that has a reactive form directive. see: https://github.com/angular/angular/blob/e2c98fbe11272295c3827b0e54f859d283cd32bf/packages/forms/src/directives/reactive_errors.ts#L64
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use the
disabledattribute on an input element that has a reactiveform directive. see: https://github.com/angular/angular/blob/e2c98fbe11272295c3827b0e54f859d283cd32bf/packages/forms/src/directives/reactive_errors.ts#L64