Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselect all with MatSelectionList is not working if mat-expansion-panel is within the list #15000

Closed
JordanFriendshuh opened this issue Jan 29, 2019 · 1 comment · Fixed by #15003
Closed

Deselect all with MatSelectionList is not working if mat-expansion-panel is within the list #15000

JordanFriendshuh opened this issue Jan 29, 2019 · 1 comment · Fixed by #15003
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@JordanFriendshuh
Copy link

When I access the MatSelectionList in code I call deselectAll() but the selectedOptions don't change at all. I would expect a layout component like mat-expansion-panel would not affect the behavior of deselectAll.

What are the steps to reproduce?

Here is an example that is most like my current code that isn't working. As you can see it's not working in this example too.
https://stackblitz.com/edit/angular-material2-issue-ua5q3b

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 7.1.4, Material 7.2.2, TS 3.1.1
@crisbeto crisbeto self-assigned this Jan 29, 2019
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jan 29, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 29, 2019
@crisbeto
fix(list): selection list not picking up indirect descendants
f30a2a3 
Fixes `MatSelectionList` not picking up list options that aren't direct descendants.

**Note:** this approach can have some side-effects if somebody decided to nested selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists.

Fixes angular#15000.
@crisbeto crisbeto mentioned this issue Jan 29, 2019
Merged
mmalerba pushed a commit that referenced this issue Jan 30, 2019
@crisbeto @mmalerba
fix(list): selection list not picking up indirect descendants (#15003)
be2bc8f 
Fixes `MatSelectionList` not picking up list options that aren't direct descendants.

**Note:** this approach can have some side-effects if somebody decided to nest selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists.

Fixes #15000.
mmalerba pushed a commit that referenced this issue Feb 4, 2019
@crisbeto @mmalerba
fix(list): selection list not picking up indirect descendants (#15003)
6a07d0d 
Fixes `MatSelectionList` not picking up list options that aren't direct descendants.

**Note:** this approach can have some side-effects if somebody decided to nest selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists.

Fixes #15000.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list): selection list not picking up indirect descendants crisbeto/material2
2 participants
@crisbeto @JordanFriendshuh